Skip to content

Revert to err logging instead of LOGS_DEFAULT macro #22720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Revert to err logging instead of LOGS_DEFAULT macro #22720

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deed106
Revert to err logging instead of LOGS_DEFAULT macro due to issue seen…
ivberg Nov 5, 2024
f631d3f
Add comment
ivberg Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onnxruntime/core/platform/windows/logging/etw_sink.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
if (FAILED(etw_status_)) {
// Registration can fail when running under Low Integrity process, and should be non-fatal
initialization_status_ = InitializationStatus::Failed;
LOGS_DEFAULT(WARNING) << "Error in ETW registration: " << std::to_string(etw_status_);
std::cerr << "Error in ETW registration: " << std::to_string(etw_status_) << std::endl;

Check warning on line 163 in onnxruntime/core/platform/windows/logging/etw_sink.cc

View workflow job for this annotation

GitHub Actions / Optional Lint C++ 

[cpplint] reported by reviewdog 🐶
 Add #include <iostream> for cerr  [build/include_what_you_use] [4]

Raw Output:
onnxruntime/core/platform/windows/logging/etw_sink.cc:163:  Add #include <iostream> for cerr  [build/include_what_you_use] [4]
}
initialization_status_ = InitializationStatus::Initialized;
}
Expand Down
Loading