Skip to content

[WebNN EP] Check if the tensor shape has 0 dimension #22573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[WebNN EP] Check if the tensor shape has 0 dimension #22573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc58605
check 0 dimension
shiyi9801 Oct 23, 2024
99d0b7e
modify log
shiyi9801 Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions onnxruntime/core/providers/webnn/builders/helper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ bool IsTensorShapeSupported(const NodeArg& node_arg, const std::string& parent_n
<< "use sessionOptions.FreeDimensionOverrides to set a fixed shape: " << node_arg_name;
return false;
}
if (dim.dim_value() == 0) {
LOGS(logger, VERBOSE) << "The shape of [" << node_arg_name << "] has 0 dimension which is not supported by WebNN";
return false;
}
}

return true;
Expand Down
4 changes: 4 additions & 0 deletions onnxruntime/core/providers/webnn/builders/impl/expand_op_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@
LOGS(logger, VERBOSE) << "Cannot get shape.";
return false;
}
if (std::any_of(new_shape.begin(), new_shape.end(), [](int64_t dimension) { return dimension == 0; })) {

Check warning on line 91 in onnxruntime/core/providers/webnn/builders/impl/expand_op_builder.cc

View workflow job for this annotation

GitHub Actions / Optional Lint C++ 

[cpplint] reported by reviewdog 🐶
 Controlled statements inside brackets of if clause should be on a separate line  [whitespace/newline] [5]

Raw Output:
onnxruntime/core/providers/webnn/builders/impl/expand_op_builder.cc:91:  Controlled statements inside brackets of if clause should be on a separate line  [whitespace/newline] [5]
LOGS(logger, VERBOSE) << "WebNN expand does not support new shape with 0 dimension.";
return false;
}

std::vector<int64_t> input_shape;
if (!GetShape(*input_defs[0], input_shape, logger)) {
Expand Down
Loading