Skip to content
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5feb7fe
add qnn instrumentation test
sheetalarkadam Oct 10, 2024
6f34b5f
add qnn browserstack
sheetalarkadam Oct 11, 2024
b75440a
skip emulator tests for qnn
sheetalarkadam Oct 11, 2024
71d4f60
skip emulator tests for qnn
sheetalarkadam Oct 11, 2024
ffea6f8
changes
sheetalarkadam Oct 12, 2024
34c1849
qnn changes,separate tests out
sheetalarkadam Oct 13, 2024
b80f5eb
pass qnn version
sheetalarkadam Oct 14, 2024
e87326c
qnn test conditional android test build
sheetalarkadam Oct 15, 2024
e8249b7
read qnn version from sdk yaml, cleanup
sheetalarkadam Oct 22, 2024
b3ffe4c
add comments
sheetalarkadam Oct 23, 2024
aa6bac0
update condtion
sheetalarkadam Oct 23, 2024
6887707
merge conflicts
sheetalarkadam Oct 23, 2024
fab730f
remove unused qnn files from test apk, indent fixes
sheetalarkadam Oct 23, 2024
572f3a2
use sdk version as stage variable and syntax fixes
sheetalarkadam Oct 23, 2024
43dea87
exclude libQnnDsp files
sheetalarkadam Oct 23, 2024
acca4ba
update comments, var names, formatting,simplify test
sheetalarkadam Oct 29, 2024
5adb321
simplify qnn_sdk_version passing, naming changes
sheetalarkadam Nov 1, 2024
939e180
use default qnn sdk parameter
sheetalarkadam Nov 1, 2024
efab87d
pipeline yaml syntax fixes
sheetalarkadam Nov 1, 2024
7c020bd
var quoting, simplify conditionals, add logs
sheetalarkadam Nov 5, 2024
d3d8d9f
Merge remote-tracking branch 'origin/main' into sak/add_android_qnn_test
sheetalarkadam Nov 6, 2024
a0e6230
update qnn sdk version
sheetalarkadam Nov 6, 2024
827a1bb
resolve conflicts
sheetalarkadam Nov 7, 2024
38e7264
resolve formatting issues
sheetalarkadam Nov 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java/src/test/android/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ Use the android's [build instructions](https://onnxruntime.ai/docs/build/android

Please note that you may need to set the `--android_abi=x86_64` (the default option is `arm64-v8a`). This is because android instrumentation test is run on an android emulator which requires an abi of `x86_64`.

#### QNN Builds
We use two AndroidManifest.xml files to manage different runtime requirements for QNN support. In the [build configuration](app/build.gradle), we specify which manifest file to use based on the qnnVersion.
In the [QNN manifest](app/src/main/AndroidManifestQnn.xml), we include the <uses-native-library> declaration for libcdsprpc.so, which is required for devices using QNN and Qualcomm DSP capabilities.
For QNN builds, it is also necessary to set the `ADSP_LIBRARY_PATH` environment variable to the [native library directory](https://developer.android.com/reference/android/content/pm/ApplicationInfo#nativeLibraryDir) depending on the device. This ensures that any native libraries downloaded as dependencies such as QNN libraries are found by the application. This is conditionally added by using the BuildConfig field IS_QNN_BUILD set in the build.gradle file.

#### Build Output

The build will generate two apks which is required to run the test application in `$YOUR_BUILD_DIR/java/androidtest/android/app/build/outputs/apk`:
Expand Down
38 changes: 37 additions & 1 deletion java/src/test/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
}

def minSdkVer = System.properties.get("minSdkVer")?:24
def qnnVersion = System.properties['qnnVersion']

android {
compileSdkVersion 32
Expand All @@ -16,6 +17,14 @@ android {
versionName "1.0"

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

// Add BuildConfig field for qnnVersion
if (qnnVersion != null) {
buildConfigField "boolean", "IS_QNN_BUILD", "true"
}
else {
buildConfigField "boolean", "IS_QNN_BUILD", "false"
}
}

buildTypes {
Expand All @@ -31,6 +40,24 @@ android {
kotlinOptions {
jvmTarget = '1.8'
}
// Conditional packagingOptions for QNN builds only
if (qnnVersion != null) {
packagingOptions {
jniLibs {
useLegacyPackaging = true
}
// Dsp is used in older QC devices and not supported by ORT
// Gpu support isn't the target, we just want Npu support (Htp)
exclude 'lib/arm64-v8a/libQnnGpu.so'
exclude 'lib/arm64-v8a/libQnnDsp*.so'
}

sourceSets {
main {
manifest.srcFile 'src/main/AndroidManifestQnn.xml' // Use QNN manifest
}
}
}
namespace 'ai.onnxruntime.example.javavalidator'
}

Expand All @@ -44,9 +71,18 @@ dependencies {
testImplementation 'junit:junit:4.+'
androidTestImplementation 'androidx.test.ext:junit:1.1.3'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
implementation(name: "onnxruntime-android", ext: "aar")

androidTestImplementation 'androidx.test:runner:1.4.0'
androidTestImplementation 'androidx.test:rules:1.4.0'
androidTestImplementation 'com.microsoft.appcenter:espresso-test-extension:1.4'

// dependencies for onnxruntime-android-qnn
if (qnnVersion != null) {
implementation(name: "onnxruntime-android-qnn", ext: "aar")
implementation "com.qualcomm.qti:qnn-runtime:$qnnVersion"
}
else {
implementation(name: "onnxruntime-android", ext: "aar")
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,18 @@ class SimpleTest {
@Test
fun runSigmoidModelTest() {
for (intraOpNumThreads in 1..4) {
runSigmoidModelTestImpl(intraOpNumThreads)
runSigmoidModelTestImpl(intraOpNumThreads, OrtProvider.CPU)
}
}

@Test
fun runSigmoidModelTestNNAPI() {
runSigmoidModelTestImpl(1, true)
runSigmoidModelTestImpl(1, OrtProvider.NNAPI)
}

@Test
fun runSigmoidModelTestQNN() {
runSigmoidModelTestImpl(1, OrtProvider.QNN)
}

@Throws(IOException::class)
Expand All @@ -54,22 +59,49 @@ class SimpleTest {
}

@Throws(OrtException::class, IOException::class)
fun runSigmoidModelTestImpl(intraOpNumThreads: Int, useNNAPI: Boolean = false) {
reportHelper.label("Start Running Test with intraOpNumThreads=$intraOpNumThreads, useNNAPI=$useNNAPI")
fun runSigmoidModelTestImpl(intraOpNumThreads: Int, executionProvider: OrtProvider) {
reportHelper.label("Start Running Test with intraOpNumThreads=$intraOpNumThreads, executionProvider=$executionProvider")
Log.println(Log.INFO, TAG, "Testing with intraOpNumThreads=$intraOpNumThreads")
Log.println(Log.INFO, TAG, "Testing with useNNAPI=$useNNAPI")
Log.println(Log.INFO, TAG, "Testing with executionProvider=$executionProvider")

val env = OrtEnvironment.getEnvironment(OrtLoggingLevel.ORT_LOGGING_LEVEL_VERBOSE)
env.use {
val opts = SessionOptions()
opts.setIntraOpNumThreads(intraOpNumThreads)
if (useNNAPI) {
if (OrtEnvironment.getAvailableProviders().contains(OrtProvider.NNAPI)) {
opts.addNnapi()
} else {
Log.println(Log.INFO, TAG, "NO NNAPI EP available, skip the test")
return

when (executionProvider) {

OrtProvider.NNAPI -> {
if (OrtEnvironment.getAvailableProviders().contains(OrtProvider.NNAPI)) {
opts.addNnapi()
} else {
Log.println(Log.INFO, TAG, "NO NNAPI EP available, skip the test")
return
}
}

OrtProvider.QNN -> {
if (OrtEnvironment.getAvailableProviders().contains(OrtProvider.QNN)) {
// Since this is running in an Android environment, we use the .so library
val qnnLibrary = "libQnnHtp.so"
val providerOptions = Collections.singletonMap("backend_path", qnnLibrary)
opts.addQnn(providerOptions)
} else {
Log.println(Log.INFO, TAG, "NO QNN EP available, skip the test")
return
}
}

OrtProvider.CPU -> {
// No additional configuration is needed for CPU
}

else -> {
// Non exhaustive when statements on enum will be prohibited in future Gradle versions
Log.println(Log.INFO, TAG, "Skipping test as OrtProvider is not implemented")
}
}

opts.use {
val session = env.createSession(readModel("sigmoid.ort"), opts)
session.use {
Expand All @@ -92,13 +124,15 @@ class SimpleTest {
output.use {
@Suppress("UNCHECKED_CAST")
val rawOutput = output[0].value as Array<Array<FloatArray>>
// QNN EP will run the Sigmoid float32 op with fp16 precision
val precision = if (executionProvider == OrtProvider.QNN) 1e-3 else 1e-6
for (i in 0..2) {
for (j in 0..3) {
for (k in 0..4) {
Assert.assertEquals(
rawOutput[i][j][k],
expected[i][j][k],
1e-6.toFloat()
precision.toFloat()
)
}
}
Expand Down
2 changes: 1 addition & 1 deletion java/src/test/android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
</activity>
</application>

</manifest>
</manifest>
23 changes: 23 additions & 0 deletions java/src/test/android/app/src/main/AndroidManifestQnn.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application
android:allowBackup="true"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/Theme.JavaValidator">
<activity android:name=".MainActivity" android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
<uses-native-library
android:name="libcdsprpc.so"
android:required="false" />
</application>

</manifest>
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
package ai.onnxruntime.example.javavalidator

import android.os.Bundle
import android.system.Os
import androidx.appcompat.app.AppCompatActivity

/*Empty activity app mainly used for testing*/
class MainActivity : AppCompatActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
if (BuildConfig.IS_QNN_BUILD) {
val adspLibraryPath = applicationContext.applicationInfo.nativeLibraryDir
// set the path variable to the native library directory
// so that any native libraries downloaded as dependencies
// (like qnn libs) are found
Os.setenv("ADSP_LIBRARY_PATH", adspLibraryPath, true)
}
super.onCreate(savedInstanceState)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ parameters:
type: string
default: ''

- name: QnnSDKVersion
displayName: QNN SDK Version
type: string
default: '2.27.0.240926'

jobs:
- job: Final_AAR_Testing_Android_${{ parameters.job_name_suffix }}
workspace:
Expand Down Expand Up @@ -50,36 +55,61 @@ jobs:

- template: use-android-ndk.yml

- template: use-android-emulator.yml
parameters:
create: true
start: true

- script: |
set -e -x
mkdir android_test
cd android_test
cp -av $(Build.SourcesDirectory)/java/src/test/android ./
cd ./android
mkdir -p app/libs
cp $(Build.BinariesDirectory)/final-android-aar/${{parameters.packageName}}-$(OnnxRuntimeVersion)${{parameters.ReleaseVersionSuffix}}.aar app/libs/onnxruntime-android.aar
$(Build.SourcesDirectory)/java/gradlew --no-daemon clean connectedDebugAndroidTest --stacktrace
displayName: Run E2E test using Emulator
set -e -x
mkdir -p android_test/android/app/libs
cd android_test/android
cp -av $(Build.SourcesDirectory)/java/src/test/android/* ./
cp $(Build.BinariesDirectory)/final-android-aar/${{parameters.packageName}}-$(OnnxRuntimeVersion)${{parameters.ReleaseVersionSuffix}}.aar app/libs/${{parameters.packageName}}.aar
displayName: Copy Android test files and AAR to android_test directory
workingDirectory: $(Build.BinariesDirectory)

- template: use-android-emulator.yml
parameters:
stop: true
# skip emulator tests for qnn package as there are no arm64-v8a emulators and no qnn libraries for x86
- ${{ if not(contains(parameters.packageName, 'qnn')) }}:
- template: use-android-emulator.yml
parameters:
create: true
start: true

- script: |
set -e -x
cd android_test/android
$(Build.SourcesDirectory)/java/gradlew --no-daemon clean connectedDebugAndroidTest --stacktrace
displayName: Run E2E test using Emulator
workingDirectory: $(Build.BinariesDirectory)

- template: use-android-emulator.yml
parameters:
stop: true

- ${{ else }}:
- script: |
# QNN SDK version string, expected format: 2.27.0.240926
# Extract the first three parts of the version string to get the Maven package version (e.g., 2.27.0)
QnnMavenPackageVersion=$(echo ${{ parameters.QnnSDKVersion }} | cut -d'.' -f1-3)
echo "QnnMavenPackageVersion: $QnnMavenPackageVersion"
echo "##vso[task.setvariable variable=QnnMavenPackageVersion]$QnnMavenPackageVersion"
displayName: Trim QNN SDK version to major.minor.patch

- script: |
set -e -x
# build apks for qnn package as they are not built in the emulator test step
$(Build.SourcesDirectory)/java/gradlew --no-daemon clean assembleDebug assembleAndroidTest -DqnnVersion=$(QnnMavenPackageVersion) --stacktrace
displayName: Build QNN APK
workingDirectory: $(Build.BinariesDirectory)/android_test/android

# we run e2e tests on one older device (Pixel 3) and one newer device (Galaxy 23)
- script: |
set -e -x
pip install requests

python $(Build.SourcesDirectory)/tools/python/upload_and_run_browserstack_tests.py \
--test_platform espresso \
--app_apk_path "debug/app-debug.apk" \
--test_apk_path "androidTest/debug/app-debug-androidTest.apk" \
--devices "Samsung Galaxy S23-13.0" "Google Pixel 3-9.0"
--devices "Samsung Galaxy S23-13.0" "Google Pixel 3-9.0" \
--build_tag "${{ parameters.packageName }}"

displayName: Run E2E tests using Browserstack
workingDirectory: $(Build.BinariesDirectory)/android_test/android/app/build/outputs/apk
timeoutInMinutes: 15
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,12 @@ stages:
enable_code_sign: ${{ parameters.DoEsrp }}
packageName: 'onnxruntime-android-qnn'
ReleaseVersionSuffix: $(ReleaseVersionSuffix)
#TODO: Add test job for QNN Android AAR

- template: android-java-api-aar-test.yml
parameters:
artifactName: 'onnxruntime-android-qnn-aar'
job_name_suffix: 'QNN'
packageName: 'onnxruntime-android-qnn'

- stage: iOS_Full_xcframework
dependsOn: []
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,29 @@ steps:
echo $(QnnSDKRootDir)
displayName: 'Print QnnSDKRootDir after downloading QNN SDK'

- script: |
set -x
sdk_file="$(QnnSDKRootDir)/sdk.yaml"
# Parse the sdk.yaml file to get the QNN SDK version downloaded
downloaded_qnn_sdk_version=$(grep '^version:' "$sdk_file" | head -n 1 | cut -d':' -f2 | xargs | cut -d'.' -f1-3 | tr -d '\r')

# Extract major.minor.patch part from QnnSDKVersion passed as parameter
expected_qnn_sdk_version=$(echo ${{ parameters.QnnSDKVersion }} | cut -d'.' -f1-3)

if [[ -z "$downloaded_qnn_sdk_version" ]]; then
echo "QNN version not found in sdk.yaml."
exit 1
fi

# Compare provided version with version from sdk.yaml
if [[ "$downloaded_qnn_sdk_version" == "$expected_qnn_sdk_version" ]]; then
echo "Success: QnnSDKVersion matches sdk.yaml version ($downloaded_qnn_sdk_version)."
else
echo "Error: QnnSDKVersion ($expected_qnn_sdk_version) does not match sdk.yaml version ($downloaded_qnn_sdk_version) in the QNN SDK directory"
exit 1
fi
displayName: "Sanity Check: QnnSDKVersion vs sdk.yaml version"

- script: |
azcopy cp --recursive 'https://lotusscus.blob.core.windows.net/models/qnnsdk/Qualcomm AI Hub Proprietary License.pdf' $(QnnSDKRootDir)
displayName: 'Download Qualcomm AI Hub license'
Expand Down
Loading
Loading