Disable using symlinks in mac-catalyst package. #21648
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rarily. The CI needs significant updates to handle creating symlinks in a nuget package.
|
Testing this alternative in parallel as it would be a better solution if it works: https://github.com/microsoft/onnxruntime/compare/skottmckay/UseZippedXcframeworkInNugetPackage |
vraspar
approved these changes
Aug 7, 2024
|
#21663 is a better fix |
skottmckay
deleted the
skottmckay/DisableCreatingCorrectPackageStructureForMacCatalyst
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable creating the correct package structure for mac-catalyst temporarily. The CI needs significant updates to handle creating symlinks in a nuget package as it will need to run on macOS or Linux instead of Windows.
This will mean a MAUI app using mac-catalyst won't be able to publish to the Apple store until resolved.
Motivation and Context
Unblock building native nuget package