Skip to content

Conversation

@divang
Copy link
Contributor

@divang divang commented Feb 27, 2025

Moved the QUOTED_IDENTIFIER and CONCAT_NULL_YIELDS_NULL flag setting in initResettableValues() method to handle the resetting of QUOTED_IDENTIFIER and CONCAT_NULL_YIELDS_NULL flag for both - new and pooled connection.

Copy link
Contributor

@lilgreenbird lilgreenbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are formatting issues, looks like the formatter wasn't run

@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 78.12500% with 14 lines in your changes missing coverage. Please review.

Project coverage is 51.67%. Comparing base (1e9cebd) to head (2d39a0d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 74.19% 7 Missing and 1 partial ⚠️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 86.36% 1 Missing and 2 partials ⚠️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 72.72% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2618      +/-   ##
============================================
+ Coverage     51.59%   51.67%   +0.08%     
- Complexity     3998     4023      +25     
============================================
  Files           147      147              
  Lines         33702    33757      +55     
  Branches       5631     5639       +8     
============================================
+ Hits          17388    17444      +56     
- Misses        13862    13881      +19     
+ Partials       2452     2432      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Divang Sharma added 3 commits March 3, 2025 19:50
…EFAULTS=ON on LOGIN7 call and CONCAT_NULL_YIELDS_NULL/QUOTED_IDENTIFIER are set ON by default.
@divang divang changed the title Blackrock: Moved the QUOTED_IDENTIFIER and CONCAT_NULL_YIELDS_NULL flag setting in initResettableValues() Blackrock: Added QUOTED_IDENTIFIER and CONCAT_NULL_YIELDS_NULL flag in connection Mar 4, 2025
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Mar 4, 2025
@divang divang dismissed lilgreenbird’s stale review April 18, 2025 11:16

Susan has handed over this project to MS team and has left the team. Her review has considered.

@divang
Copy link
Contributor Author

divang commented Apr 18, 2025

ADO pipeline is successful.

Copy link
Collaborator

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. Just a couple questions/comments.

@divang
Copy link
Contributor Author

divang commented Apr 21, 2025

@microsoft-github-policy-service agree [company="{your company}"]

@divang divang closed this Apr 21, 2025
@divang divang reopened this Apr 21, 2025
@github-project-automation github-project-automation bot moved this from Under Peer Review to In progress in MSSQL JDBC Apr 21, 2025
@divang
Copy link
Contributor Author

divang commented Apr 21, 2025

@divang please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@divang
Copy link
Contributor Author

divang commented Apr 21, 2025

@microsoft-github-policy-service agree company="Microsoft"

@divang divang merged commit 3e8672a into main Apr 21, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Closed/Merged PRs in MSSQL JDBC Apr 21, 2025
@David-Engel David-Engel added this to the 12.11.0 milestone May 9, 2025
@David-Engel David-Engel changed the title Blackrock: Added QUOTED_IDENTIFIER and CONCAT_NULL_YIELDS_NULL flag in connection Added QUOTED_IDENTIFIER and CONCAT_NULL_YIELDS_NULL flag in connection Jun 10, 2025
@divang divang deleted the blackrock branch June 11, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed/Merged PRs

Development

Successfully merging this pull request may close these issues.

6 participants