-
Notifications
You must be signed in to change notification settings - Fork 443
Added QUOTED_IDENTIFIER and CONCAT_NULL_YIELDS_NULL flag in connection #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in initResettableValues() method to handle it in pooled connection too
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
… and CONCAT_NULL_YIELDS_NULL
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are formatting issues, looks like the formatter wasn't run
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
============================================
+ Coverage 51.59% 51.67% +0.08%
- Complexity 3998 4023 +25
============================================
Files 147 147
Lines 33702 33757 +55
Branches 5631 5639 +8
============================================
+ Hits 17388 17444 +56
- Misses 13862 13881 +19
+ Partials 2452 2432 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…EFAULTS=ON on LOGIN7 call and CONCAT_NULL_YIELDS_NULL/QUOTED_IDENTIFIER are set ON by default.
…s are not supplied (server default case)
… value for new and pooled connection
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
…g with ON value and helper method
… and QUOTED_IDENTIFIER values, suppilied in connection properties
Susan has handed over this project to MS team and has left the team. Her review has considered.
|
ADO pipeline is successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. Just a couple questions/comments.
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
…d catch block in new test cases
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@microsoft-github-policy-service agree company="Microsoft" |
Moved the QUOTED_IDENTIFIER and CONCAT_NULL_YIELDS_NULL flag setting in initResettableValues() method to handle the resetting of QUOTED_IDENTIFIER and CONCAT_NULL_YIELDS_NULL flag for both - new and pooled connection.