-
Couldn't load subscription status.
- Fork 442
Fixed issue for finding mssql-jdbc.properties location in test environments
#2579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…utOfBoundsExcelption
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
============================================
+ Coverage 51.22% 51.37% +0.15%
- Complexity 3953 3978 +25
============================================
Files 147 147
Lines 33657 33665 +8
Branches 5624 5627 +3
============================================
+ Hits 17241 17296 +55
+ Misses 13999 13936 -63
- Partials 2417 2433 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
mssql-jdbc.properties location logicmssql-jdbc.properties location logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java:287
- The variable 'locationSuffix' is defined but not used consistently. Consider using 'locationSuffix.length()' instead of hardcoding the length value (16) on line 291.
String locationSuffix = "target/classes/";
|
ADO test runs were good for this change. |
mssql-jdbc.properties location logicmssql-jdbc.properties location in test environments
The logic for finding the
mssql-jdbc.propertiesfile, used in Configurable Retry Logic was correct for test environments, and when building the driver manually, but not correct when using the driver as a jar or dependency. This fixes that issue by only removing thetarget/classessuffix if needed.