Connection level bulk copy metadata caching #2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barryw-mssql
previously approved these changes
Jul 3, 2024
lilgreenbird
reviewed
Jul 3, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Jul 3, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
Jul 4, 2024
src/main/java/com/microsoft/sqlserver/jdbc/ISQLServerConnection.java
Outdated
Show resolved
Hide resolved
barryw-mssql
previously approved these changes
Jul 4, 2024
David-Engel
reviewed
Jul 5, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
Outdated
Show resolved
Hide resolved
barryw-mssql
previously approved these changes
Jul 5, 2024
Jeffery-Wasty
previously approved these changes
Jul 5, 2024
|
@microsoft-github-policy-service agree company="Microsoft" |
Jeffery-Wasty
previously approved these changes
Jul 5, 2024
tkyc
dismissed
Jeffery-Wasty’s stale review
The merge-base changed after approval.
barryw-mssql
previously approved these changes
Jul 5, 2024
Jeffery-Wasty
previously approved these changes
Jul 5, 2024
tkyc
dismissed stale reviews from Jeffery-Wasty and barryw-mssql
The merge-base changed after approval.
Jeffery-Wasty
previously approved these changes
Jul 5, 2024
barryw-mssql
previously approved these changes
Jul 5, 2024
tkyc
dismissed stale reviews from barryw-mssql and Jeffery-Wasty
The merge-base changed after approval.
tkyc
force-pushed
the
bulkcopy-conn-lvl-cache
branch
from
cbcfa45 to
77f8f78
Compare
Jeffery-Wasty
approved these changes
Jul 5, 2024
barryw-mssql
approved these changes
Jul 5, 2024
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cacheBulkCopyMetadataboolean connection property.Caveat: If the table changes in any way (column definition, new columns, deleted columns, etc..), then during a bulk copy the operation may or may not error out when caching is enabled. Just a note that there could be unintended consequences without warning.