Fixed CallableStatement default value regression #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Fixed
Show fixed
Hide fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2452 +/- ##
============================================
- Coverage 50.81% 50.73% -0.08%
+ Complexity 3882 3873 -9
============================================
Files 145 145
Lines 33423 33423
Branches 5677 5677
============================================
- Hits 16983 16957 -26
- Misses 13999 14024 +25
- Partials 2441 2442 +1 ☔ View full report in Codecov by Sentry. |
Jeffery-Wasty
requested review from
Jeffery-Wasty,
barryw-mssql and
lilgreenbird
| private static String outputProcedureNameGUID = AbstractSQLGenerator | ||
| .escapeIdentifier(RandomUtil.getIdentifier("uniqueidentifier_SP")); | ||
| private static String setNullProcedureName = AbstractSQLGenerator | ||
| .escapeIdentifier(RandomUtil.getIdentifier("CallableStatementTest_setNull_SP")); |
There was a problem hiding this comment.
Run formatter on file.
tkyc
force-pushed
the
cstmt-default-value
branch
from
1123d68 to
652b764
Compare
Jeffery-Wasty
approved these changes
Jun 19, 2024
lilgreenbird
approved these changes
Jun 19, 2024
tkyc
added a commit
that referenced
this pull request
Jun 19, 2024
* Fixed default value regression for cstmts * Adjusted regex * Test update * Updated test p2 * Updated regex
Jeffery-Wasty
added a commit
that referenced
this pull request
Aug 6, 2024
This reverts commit 9307051.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2446