Fixed incorrect updateCount #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Outdated
Show resolved
Hide resolved
Jeffery-Wasty
previously approved these changes
Dec 23, 2022
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
approved these changes
Dec 28, 2022
Jeffery-Wasty
approved these changes
Dec 28, 2022
tkyc
added a commit
that referenced
this pull request
Dec 28, 2022
* Fixed incorrect updateCount * Formatting changes * Additional testing and changes * Removed debug print line
tkyc
added a commit
that referenced
this pull request
Dec 28, 2022
* Fixed incorrect updateCount * Formatting changes * Additional testing and changes * Removed debug print line
This was referenced Dec 28, 2022
tkyc
added a commit
that referenced
this pull request
Dec 29, 2022
* Fixed incorrect updateCount * Formatting changes * Additional testing and changes * Removed debug print line
tkyc
added a commit
that referenced
this pull request
Dec 29, 2022
tkyc
added a commit
that referenced
this pull request
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1961. The incorrect update count can happen in both true/false cases for
enablePrepareOnFirstPreparedStatementCalland for both prepexec/prepare.