Cache parameter metadata secure #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ell as refactored code to remove dependency on statics.
Jeffery-Wasty
added
Under Review
Jeffery-Wasty
removed
the
Work in Progress
Contributor
|
/azp run public-mssql-jdbc.linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tkyc
reviewed
Jul 14, 2022
src/main/java/com/microsoft/sqlserver/jdbc/ParameterMetaDataCache.java
Outdated
Show resolved
Hide resolved
tkyc
reviewed
Jul 14, 2022
src/main/java/com/microsoft/sqlserver/jdbc/ParameterMetaDataCache.java
Outdated
Show resolved
Hide resolved
…n ParameterMetadataCache, removed.
tkyc
reviewed
Jul 15, 2022
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/ParameterMetaDataCacheTest.java
Show resolved
Hide resolved
David-Engel
reviewed
Jul 15, 2022
src/main/java/com/microsoft/sqlserver/jdbc/ParameterMetaDataCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/ParameterMetaDataCache.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/ParameterMetaDataCacheTest.java
Outdated
Show resolved
Hide resolved
…gic was flawed, fixed. Cleanup. Removed unused code.
…or AE_v3, as they will cause failure in our pipelines.
Jeffery-Wasty
commented
Jul 18, 2022
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/ParameterMetaDataCacheTest.java
Outdated
Show resolved
Hide resolved
Jeffery-Wasty
commented
Jul 18, 2022
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/ParameterMetaDataCacheTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/ParameterMetaDataCache.java
Outdated
Show resolved
Hide resolved
… retry and used that to skip AEv2 instead.
src/main/java/com/microsoft/sqlserver/jdbc/ParameterMetaDataCache.java
Outdated
Show resolved
Hide resolved
tkyc
reviewed
Jul 18, 2022
src/main/java/com/microsoft/sqlserver/jdbc/ParameterMetaDataCache.java
Outdated
Show resolved
Hide resolved
tkyc
previously approved these changes
Jul 19, 2022
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/ParameterMetaDataCacheTest.java
Outdated
Show resolved
Hide resolved
… removed unneeded con.close() statements.
lilgreenbird
previously approved these changes
Jul 19, 2022
…al machines, this needs to be changed back to 0 and was not done so. Fixed.
tkyc
previously approved these changes
Jul 19, 2022
lilgreenbird
previously approved these changes
Jul 19, 2022
David-Engel
reviewed
Jul 20, 2022
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
VeryVerySpicy
previously approved these changes
Jul 20, 2022
…nection, for better clarity.
Jeffery-Wasty
dismissed stale reviews from VeryVerySpicy, lilgreenbird, and tkyc
via
4ea1794
lilgreenbird
approved these changes
Jul 20, 2022
VeryVerySpicy
approved these changes
Jul 20, 2022
tkyc
approved these changes
Jul 20, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends previous cache parameter metadata function for secure enclaves. Secure enclaves must support retrying the enclave when the session is no longer valid (Always Encrypted version 3).