Avoid String use with secure strings #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryVerySpicy
approved these changes
Apr 26, 2022
lilgreenbird
approved these changes
Apr 26, 2022
tkyc
approved these changes
Apr 26, 2022
Jeffery-Wasty
approved these changes
Apr 27, 2022
mmimica
reviewed
Jun 30, 2022
| if (chars == null) | ||
| return null; | ||
| SecureRandom random = new SecureRandom(); | ||
| random.nextBytes(iv); |
There was a problem hiding this comment.
This is very fragile. Out of order encrypt-decrypt calls will not work because iv is stored in instance variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Strings are immutable in Java and tend to stay around in memory for potential re-use in the JVM, it's best practice to avoid them for sensitive data. It's recommended to use char arrays instead and clear/overwrite them once they're no longer needed. This limits the amount of time sensitive data remains in memory.