Formatted the check that assigns AE version to correctly assign version to protocol #1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilgreenbird
previously approved these changes
Apr 14, 2022
David-Engel
reviewed
Apr 14, 2022
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
David-Engel
approved these changes
Apr 18, 2022
raghavthind2005
approved these changes
Apr 19, 2022
tkyc
approved these changes
Apr 19, 2022
VeryVerySpicy
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous commit for attestation protocol, the check to assign the correct AE version in SQLServerConnection, 1) mistakenly assigned V1 to all HGS,AAS protocols and 2) assigned V2 to null protocols. By reformatting, the check should now correctly assign version for all cases of attestation URL and protocol.
Also included the version change in SQLJdbcVersion as it was needed to properly test that this fix was working.