Skip to content

Retry randomUUID() to mitigate intermittent java NativeSeedGenerator failure #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Retry randomUUID() to mitigate intermittent java NativeSeedGenerator failure #1705

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02885c6
Retry once
Dec 6, 2021
bb3fd76
Added logging
Dec 8, 2021
f66bbef
Changed logging level
Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3214,7 +3214,17 @@ private InetSocketAddress connectHelper(ServerPortPlaceHolder serverInfo, int ti

setState(State.Connected);

clientConnectionId = UUID.randomUUID();
try {
clientConnectionId = UUID.randomUUID();
} catch (InternalError e) {
// Java's NativeSeedGenerator can sometimes fail on getSeedBytes(). Exact reason is unknown but high system
// load seems to contribute to likelihood. Retry once to mitigate.
if (connectionlogger.isLoggable(Level.FINER)) {
connectionlogger.finer(toString() + " Generating a random UUID has failed due to : " + e.getMessage() + "Retrying once.");
}
clientConnectionId = UUID.randomUUID();
}

assert null != clientConnectionId;

Prelogin(serverInfo.getServerName(), serverInfo.getPortNumber());
Expand Down