11.2.0 fails to deploy in OSGi environment without msal4j

[MrEasy]

Driver version

11.2.0

SQL Server version

Microsoft SQL Server 2019 (RTM-GDR) (KB5014356) - 15.0.2095.3 (X64) Apr 29 2022 18:00:13 Copyright (C) 2019 Microsoft Corporation Developer Edition (64-bit) on Windows 10 Pro 10.0 (Build 22000: ) (Hypervisor)
(but unrelated to issue)

Client Operating System

Win 11 (but unrelated)

JAVA/JVM version

17.0.4 (but unrelated)

Problem description

This change here:

• Added explicit dependency for com.microsoft.azure.msal4j (was a transitive dependency in previous releases) 1863

introduced an explicit dependency on msal4j (which is good compared to the transitive before), but seems to have missed to flag it as optional, like the others.
ef14c5b

As a result, the driver will not deploy anymore in an OSGi environment without that dependency:
org.apache.felix.resolver.reason.ReasonException: Unable to resolve com.microsoft.sqlserver.mssql-jdbc/11.2.0: missing requirement [com.microsoft.sqlserver.mssql-jdbc/11.2.0] osgi.wiring.package; filter:="(&(osgi.wiring.package=com.microsoft.aad.msal4j)(version>=1.13.0)(!(version>=2.0.0)))"

I think this was just missed, since the optional check is still there:

mssql-jdbc/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java

Line 5576 in 7f9a984

private boolean msalContextExists() {

Expected behavior

Dependency declared optional and deploying without successfully.

[MrEasy]

PR: #1893
Works fine again with this change.

[Jeffery-Wasty]

Hi @MrEasy,

Thanks for bringing this to our attention. You may be right, I'll look through our requirements again, but this should be a quick yes/no.

[lilgreenbird]

hi @MrEasy
Thank you for bringing this to our attention. You are correct we will get this fixed in an upcoming 11.2.1 release.