Add properties to set SearchClient settings like Temperature and TopP #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dluc
requested changes
Mar 5, 2024
dluc
approved these changes
Mar 5, 2024
Merged
dluc
added a commit
that referenced
this pull request
Mar 7, 2024
## Motivation and Context (Why the change? What's the scenario?) Address #340, allow to run the service with serverless settings. Fix config syntax error introduced in #341 Requires a release and follow up PR to upgrade Core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context (Why the change? What's the scenario?)
With the exception of
MaxTokens, properties of the TextGenerationOptions object used byAskAsyncare hard-coded.High level description (Approach, Design)
This PR addresses issues https://github.com/microsoft/kernel-memory/issues/137 and https://github.com/microsoft/kernel-memory/issues/337. It updates the SearchClientConfig.cs file in the Abstractions project adding the properties that allows to set Temperature, TopP, PresencePenaltiy, etc.
Once the Abstractions project is updated on NuGet, the Core project can be in turn modified to use these new settings in the SearchClient.cs file.