Swap EvalSymlinks with ResolvePath
#2455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redo PR 1644, which swapped builtin `"path/filepath".EvalSymlinks` with `"github.com/Microsoft/go-winio/pkg/fs".ResolvePath`, since the later is able to handle deeply nested symlinks and (as of [go1.23](golang.org/doc/go1.23#pathfilepathpkgpathfilepath)), mountpoints. Signed-off-by: Hamza El-Saawy <[email protected]>
msscotb
approved these changes
Jun 13, 2025
|
nit: It would be nice to also update the test code at: https://github.com/microsoft/hcsshim/blob/main/test/functional/make_uvm_cim_test.go#L25, but it is not urgent, so if we need to get this in immediately, we can include that in a later PR. |
ambarve
approved these changes
Jun 16, 2025
Signed-off-by: Hamza El-Saawy <[email protected]>
ambarve
approved these changes
Jun 16, 2025
Merged
helsaawy
added a commit
that referenced
this pull request
Jun 16, 2025
* [backport]Trim LCOW `GetProperties` response (#2458) * Trim LCOW `GetProperties` response Zero out the Linux `GetProperties` `Blkio` field, since it scales with the number of container layers attacked to the uVM. Additionally empty the `Rdma` and `Network` fields, in case they can also grow without bound. None of the fields are used in any code paths in the AzCRI, or exposed elsewhere. Clarify comment about the maximum message size, to reflect that it mirrors and HCS value and is not arbitrary. Additionally, don't quit the receive loop if the message size is too large, since that brings the bridge down with it. Signed-off-by: Hamza El-Saawy <[email protected]> * PR: undo receive loop changes Signed-off-by: Hamza El-Saawy <[email protected]> --------- Signed-off-by: Hamza El-Saawy <[email protected]> (cherry picked from commit a53730e) Signed-off-by: Hamza El-Saawy <[email protected]> * [backport]Swap `EvalSymlinks` with `ResolvePath` (#2455) * Swap `EvalSymlinks` with `ResolvePath` Redo PR 1644, which swapped builtin `"path/filepath".EvalSymlinks` with `"github.com/Microsoft/go-winio/pkg/fs".ResolvePath`, since the later is able to handle deeply nested symlinks and (as of [go1.23](golang.org/doc/go1.23#pathfilepathpkgpathfilepath)), mountpoints. Signed-off-by: Hamza El-Saawy <[email protected]> * PR: update CIM test code Signed-off-by: Hamza El-Saawy <[email protected]> --------- Signed-off-by: Hamza El-Saawy <[email protected]> (cherry picked from commit e3722b0) Signed-off-by: Hamza El-Saawy <[email protected]> --------- Signed-off-by: Hamza El-Saawy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo PR #1644, which swapped builtin
"path/filepath".EvalSymlinkswith"github.com/Microsoft/go-winio/pkg/fs".ResolvePath, since the later is able to handle deeply nested symlinks and (as ofgo 1.23), mountpoints.