Skip to content

Add Milvus vector store #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Milvus vector store #376

wants to merge 2 commits into from
+385 −12

Conversation

zc277584121
Copy link

@zc277584121 zc277584121 commented Jul 5, 2024 •
edited
Loading 

vdb = MilvusVectorStore(collection_name="GraphRAG")

vdb.connect(uri="./milvus.db")
# vdb.connect(uri="http://10.100.30.11:19530")

vdb.load_documents(...)
vdb.similarity_search_by_vector(...)
vdb.similarity_search_by_text(...)

@zc277584121 zc277584121 requested a review from a team as a code owner July 5, 2024 09:35
@zc277584121
Copy link
Author

@microsoft-github-policy-service agree company="zilliz"

@zc277584121
Copy link
Author

Currently milvus do not support higher version of environs, so we change it into environs = "^9.5.0", but from what I have tested, it does not affect other normal usage.

@xiaofan-luan
Copy link

glad to know milvus is supported! looking forward to it

@zc277584121
Copy link
Author

@AlonsoGuevara, Could you please help to review it ?

@AlonsoGuevara
Copy link
Collaborator

Hi @zc277584121
I have this PR and the Qdrant one on my radar. Sorry for any delay, I'm currently thinking on the approach we should take for community contributions, to make it easy without much coupling.

@hemangjoshi37a
Copy link

please let me know if milvus is possible to integrate with this . thanks

@AlonsoGuevara AlonsoGuevara mentioned this pull request Jul 12, 2024
Closed
@hemangjoshi37a
Copy link

hemangjoshi37a commented Jul 13, 2024 •
edited
Loading

Mentioning reference issue #526

@zc277584121
Merge remote-tracking branch 'remote_origin/main'
c726393 
Signed-off-by: ChengZi <[email protected]>

# Conflicts:
#	poetry.lock
#	pyproject.toml
@zc277584121 zc277584121 reopened this Jul 18, 2024
@zc277584121
Copy link
Author

please ping me when you finish refactoring, thanks

@cbornet cbornet mentioned this pull request Sep 23, 2024
Open
4 tasks
@jgbradley1 jgbradley1 changed the title feat: Milvus vector storage Add Milvus vector storage Oct 15, 2024
@jgbradley1 jgbradley1 changed the title Add Milvus vector storage Add Milvus vector store Oct 15, 2024
@NiuBlibing
Copy link

NiuBlibing commented Dec 4, 2024 •
edited
Loading

@zc277584121 @hemangjoshi37a Hi, pymilvus 2.5.0 had already removed environs: milvus-io/pymilvus#2192. Is it time to merge this?

@basitanees
Copy link

Hi, is there any update about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@atharvamungee atharvamungee atharvamungee approved these changes

@AIinMinutes AIinMinutes AIinMinutes approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zc277584121 @xiaofan-luan @AlonsoGuevara @hemangjoshi37a @NiuBlibing @basitanees @atharvamungee @AIinMinutes