-
Notifications
You must be signed in to change notification settings - Fork 85
[WIP] Parse does not recognize Pwd as a valid password field alias #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: shueybubbles <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 75.16% 75.07% -0.10%
==========================================
Files 32 32
Lines 6471 6471
==========================================
- Hits 4864 4858 -6
- Misses 1322 1327 +5
- Partials 285 286 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add an entry to the connStrings array in TestValidConnectionString in msdsn/conn_str_test.go to test this new parameter. |
Co-authored-by: shueybubbles <[email protected]>
Added a test in msdsn/pwd_test.go that verifies the "pwd" alias works correctly in connection strings in 312bb45. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issue #262 by updating the Parse function to recognize "pwd" as a valid alias for the password field in connection strings. Key changes include adding the "pwd" entry to the adoSynonyms map, adding a corresponding test case, updating the driver version in version.go, and updating the changelog.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
version.go | Bumped driver version from v1.8.0 to v1.8.2 |
msdsn/conn_str.go | Added a new alias "pwd" mapping to the Password field |
msdsn/conn_str_test.go | Added test case to verify the "pwd" alias mapping |
CHANGELOG.md | Updated changelog with the bug fix entry |
Comments suppressed due to low confidence (1)
msdsn/conn_str_test.go:110
- [nitpick] Consider adding additional test cases for alternate casings (e.g., "PWD", "Pwd") if the parsing is expected to be case-insensitive, ensuring comprehensive alias mapping validation.
{"pwd=placeholder", func(p Config) bool { return p.Password == "placeholder" }},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #262.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.