Skip to content

Conversation

@benpeart
Copy link

@benpeart benpeart commented Oct 8, 2018

Reverts a stale GVFS specific perf test and removes the GVFS specific optimization to avoid computing the SHA1-1 on index load which is no longer needed.

This reverts commit 2e88564.

This test has been broken since:

5fbe600 t/helper: merge test-read-cache into test-tool

and hasn't been needed since:

a33fc72 read-cache: force_verify_index_checksum

which accomplishes the same goal.

Signed-off-by: Ben Peart <[email protected]>
@benpeart benpeart requested a review from kewillford October 8, 2018 18:20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove _READ?

Remove the gvfs specific test which allowed us to skip the SHA1-1 verification
as it has not been needed since master accepted:

a33fc72 read-cache: force_verify_index_checksum

which accomplishes the same goal.

Signed-off-by: Ben Peart <[email protected]>
@benpeart benpeart merged commit d82c8c1 into microsoft:gvfs-2.19.0 Oct 10, 2018
derrickstolee added a commit to microsoft/VFSForGit that referenced this pull request Oct 12, 2018
…racked files

Update the package for GitForWindows to include tracing information.

Includes the following Git PRs:

* [36 Avoid `sane_execvp` in `git rebase` and `git stash`](microsoft/git#36)
* [34 Add Trace2 regions to 'pack-objects'](microsoft/git#34)
* [28 Trace2 base plus GVFS extensions](microsoft/git#28)
* [33 virtualfilesystem: check if directory is included](microsoft/git#33)
* [31 Revert "gvfs: add a perf test for reading the index"](microsoft/git#31)
* [32 compat/poll: prepare for targeting Windows Vista](microsoft/git#32)
* [22 Enable the filesystem cache (fscache) in refresh_index()](microsoft/git#22)
* [27 virtualfilesystem: fix bug with symlinks being ignored](microsoft/git#27)
* [23 Unpack trees with cache tree gvfs](microsoft/git#23)
* [15 virtualfilesystem: don't run the virtual file system hook if the index has been redirected](microsoft/git#15)
* Includes Git 2.19.0.

This also includes VFS for Git updates from Kevin Willford's work:

**Fix missing untracked files when created in subfolder**

Add to the test to create multiple level of folders and files in those folder to make sure they show up as untracked files.

Update the git for windows version that has the fix.

Fixes #358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants