unpack-trees: add trace2 regions around each use #132
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unpack_trees() method has many uses, and each can have
different performance characteristics. Create trace2 regions
around each call so we can measure the cost of this method
in each situation.
These instances were found by grepping for the
setup_unpack_trees_porcelain() method, which is called before
every actual call to unpack_trees(). Searching for
unpack_trees() finds many false-positives in comments
and documentation.
This is for gathering data on the impact unpack_trees()
is having on different commands. This PR should wait for
the 2.21.0 update (#122), but I'll use it to generate an
installer for local testing in the meantime.