Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 13, 2021

Bumps react-native-test-app from 0.9.19 to 0.9.20.

Release notes

Sourced from react-native-test-app's releases.

0.9.20

0.9.20 (2021-12-13)

Bug Fixes

  • windows: remove the self-signed test certificate (#648) (baa2b47)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [react-native-test-app](https://github.com/microsoft/react-native-test-app) from 0.9.19 to 0.9.20.
- [Release notes](https://github.com/microsoft/react-native-test-app/releases)
- [Commits](microsoft/react-native-test-app@0.9.19...0.9.20)

---
updated-dependencies:
- dependency-name: react-native-test-app
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the Type: Dependencies Pull requests that update a dependency file label Dec 13, 2021
@ghost ghost added the AutoMerge 🔁 Automatically merge when PR requirements met label Dec 13, 2021
@ghost
Copy link

ghost commented Dec 13, 2021

Hello @msftbot[bot]!

Because this pull request has the AutoMerge :repeat: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@rurikoaraki
Copy link
Collaborator

Hey @tido64 we're running into issues with building the windows test solution with this change. The error is

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VisualStudio\v17.0\AppxPackage\Micros oft.AppXPackage.Targets(3496,5): error APPX0101: A signing key is required in order to package this project. Ple ase specify a PackageCertificateKeyFile or PackageCertificateThumbprint value in the project file. [E:\fluentui- react-native\apps\windows\node_modules\.generated\windows\ReactTestApp\ReactTestApp.vcxproj]

which seems related to the change made. Would you have any suggestions on what's going on and how to fix this?

@Saadnajmi
Copy link
Collaborator

Hey @tido64 we're running into issues with building the windows test solution with this change. The error is

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VisualStudio\v17.0\AppxPackage\Micros oft.AppXPackage.Targets(3496,5): error APPX0101: A signing key is required in order to package this project. Ple ase specify a PackageCertificateKeyFile or PackageCertificateThumbprint value in the project file. [E:\fluentui- react-native\apps\windows\node_modules\.generated\windows\ReactTestApp\ReactTestApp.vcxproj]

which seems related to the change made. Would you have any suggestions on what's going on and how to fix this?

As an FYI, he's oof till January I believe

@tido64
Copy link
Member

tido64 commented Dec 16, 2021

0.9.21 should fix this issue. Let me know if you still hit it.

@Saadnajmi Saadnajmi closed this Dec 16, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 16, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@Saadnajmi Saadnajmi deleted the dependabot/npm_and_yarn/react-native-test-app-0.9.20 branch December 16, 2021 16:47
@rurikoaraki
Copy link
Collaborator

Thanks @tido64 for looking into this!

@Saadnajmi Saadnajmi restored the dependabot/npm_and_yarn/react-native-test-app-0.9.20 branch December 17, 2021 01:47
@Saadnajmi Saadnajmi reopened this Dec 17, 2021
@Saadnajmi
Copy link
Collaborator

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 17, 2021

Superseded by #1264.

@dependabot dependabot bot closed this Dec 17, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/react-native-test-app-0.9.20 branch December 17, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge 🔁 Automatically merge when PR requirements met Type: Dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants