Fix regression in useAsPressable #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
With #1061 , #1063, and #1068, I made a bunch of changes to useAsPressable and it's siblings to try and have it work better with both the RN Core Pressable, and our port of Pressability. There is one more bug fix (sigh) I need to make, where I caused a regression in useAsPressable and hover effects are no longer showing properly on controls that use useAsPressable.
Verification
I tested this on macOS and win32, and had a second person test on win32 for triple check sanity, as it's the end of our Hackathon week.
Pull request checklist
This PR has considered (when applicable):