Implemented App and DB level concurrency management for Search parameter upates #5097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter Implemented Datastore level optimistic concurrency for Search Parameter
jestradaMS
added
Azure Healthcare APIs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/SearchParameterOperations.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/SearchParameterOperations.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/SearchParameterOperations.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.Core/Features/Search/Registry/SearchParameterConcurrencyManager.cs
Fixed
Show fixed
Hide fixed
...Microsoft.Health.Fhir.SqlServer/Features/Storage/Registry/SearchParameterStatusCollection.cs
Fixed
Show fixed
Hide fixed
...t.Health.Fhir.SqlServer/Features/Storage/Registry/SqlServerSearchParameterStatusDataStore.cs
Dismissed
Show dismissed
Hide dismissed
...t.Health.Fhir.SqlServer/Features/Storage/Registry/SqlServerSearchParameterStatusDataStore.cs
Fixed
Show fixed
Hide fixed
Fixed issue with release timing of semaphore
jestradaMS
added
Enhancement
...ealth.Fhir.Core.UnitTests/Features/Search/Registry/SearchParameterConcurrencyManagerTests.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.Core/Features/Search/Registry/SearchParameterConcurrencyManager.cs
Fixed
Show fixed
Hide fixed
...Shared.Tests.Integration/Persistence/SearchParameterOptimisticConcurrencyIntegrationTests.cs
Fixed
Show fixed
Hide fixed
Updated integration test error handling
src/Microsoft.Health.Fhir.Core/Features/Search/Registry/SearchParameterConcurrencyManager.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.Core/Features/Search/Registry/SearchParameterConcurrencyManager.cs
Fixed
Show fixed
Hide fixed
...Shared.Tests.Integration/Persistence/SearchParameterOptimisticConcurrencyIntegrationTests.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.Core/Features/Search/Registry/SearchParameterConcurrencyManager.cs
Dismissed
Show dismissed
Hide dismissed
…e on SearchParam table
| /// <summary> | ||
| /// Exception thrown when an optimistic concurrency conflict occurs during search parameter updates. | ||
| /// </summary> | ||
| public class SearchParameterConcurrencyException : Exception |
There was a problem hiding this comment.
Is this exception used anywhere? I don't see any references to it in this PR.
| var tableValuedParameter = new SqlParameter | ||
| { | ||
| ParameterName = "searchParamStatuses", | ||
| SqlDbType = SqlDbType.Structured, | ||
| Value = collection, | ||
| Direction = ParameterDirection.Input, | ||
| TypeName = "dbo.SearchParamTableType_2", |
There was a problem hiding this comment.
I think this will be the problem with backwards compatibility. The old code will pass in a type that the new stored procedure isn't expecting as an input.
| @@ -353,11 +354,6 @@ object IServiceProvider.GetService(Type serviceType) | |||
| return _testHelper; | |||
| } | |||
|
|
|||
| if (serviceType.IsInstanceOfType(this)) | |||
There was a problem hiding this comment.
Why remove this? It doesn't look useful at all, but I'm curious why it caught your attention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves critical race conditions in SearchParameter operations that occurred when multiple concurrent requests attempted to create, update, or delete the same SearchParameter resource simultaneously. This implementation introduces a robust two-layer concurrency control strategy combining application-level pessimistic locking with database-level optimistic concurrency.
Related issues
Addresses race condition issues where concurrent SearchParameter updates would fail unpredictably, particularly in high-load environments with multiple FHIR server instances.
AB#164155
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Feature - New concurrency management capabilities with backward compatibility