Skip to content

address warnings: Node.js 16 actions are deprecated. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

address warnings: Node.js 16 actions are deprecated. #339

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
736081a
address warnings: Node.js 16 actions are deprecated. Please update th…
fedordikarev May 14, 2024
9982a54
add current branch for manual testing workflow
fedordikarev May 14, 2024
a1c8e31
fix
fedordikarev May 14, 2024
d887e4f
fix warnings base option should start|end with a slash.
fedordikarev May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
pull_request:
branches:
- main
- fix/github-actions-node-16-to-node-20
permissions:
packages: write
contents: write
Expand All @@ -23,7 +24,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: "16"
node-version: "20"
cache: "npm"
cache-dependency-path: frontend/package-lock.json

Expand All @@ -32,7 +33,7 @@ jobs:
working-directory: frontend

- name: Build Static Web App
run: npm run build -- --base=$BASE_URL
run: npm run build -- --base=/$BASE_URL/
env:
BASE_URL: ${{ github.event.repository.name }}
VITE_FACE_API_KEY: ${{ secrets.VITE_FACE_API_KEY }}
Expand Down Expand Up @@ -62,7 +63,7 @@ jobs:
- uses: actions/setup-node@v3
if: github.repository_owner == 'microsoft'
with:
node-version: "14"
node-version: "20"

- run: npm init -y
if: github.repository_owner == 'microsoft'
Expand Down