Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Added 'No internet connection' message when device is offline #3873

Merged
AmelBawa-msft merged 2 commits into from
Sep 23, 2024
Merged

Added 'No internet connection' message when device is offline #3873

AmelBawa-msft merged 2 commits into from
Sep 23, 2024

Conversation

@AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Sep 16, 2024

Summary of the pull request

  • When device is offline, display a message to the user instead of showing an empty space in case (e.g. if winget source is not yet hydrated or search involves the store)
     
    NoInternetConnection

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@AmelBawa-msft AmelBawa-msft requested a review from a team September 17, 2024 16:55
@AmelBawa-msft AmelBawa-msft added the Needs-Second Pull request that needs another approval label Sep 23, 2024
@krschau krschau removed the Needs-Second Pull request that needs another approval label Sep 23, 2024
@AmelBawa-msft AmelBawa-msft merged commit e6c0d16 into main Sep 23, 2024
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa/1000 branch September 23, 2024 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@dhoehna dhoehna dhoehna approved these changes

@krschau krschau krschau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

App does not list any available apps when device is offline

4 participants

@AmelBawa-msft @dhoehna @krschau