This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Remove NT service registration from Retail build of DevHome #3870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkur
requested review from
andreww-msft,
dabhattimsft,
jaholme,
krschau,
mathewleeza,
xhan65 and
zadesai
zadesai
approved these changes
Sep 16, 2024
EricJohnson327
pushed a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Remove the NT service registration from the retail build of DevHome until we finish some bookkeeping tasks.
This will prevent DevDiagnostics from monitoring processes that failed to launch due to loader dependencies, but everything else should be fine.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
Built retail. Installed the build, confirmed no NT service was installed, and DevDiagnostics still launched properly.
PR checklist