This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fix crash in SimpleTextInsights #3853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmelBawa-msft
approved these changes
Sep 13, 2024
zadesai
approved these changes
Sep 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
We were creating the control on the wrong thread. Now we queue the creation onto the UI thread, and wait for this to complete.
Also fixed the loader snaps insights text to wrap.
Also fixed the windows logs row text to wrap (but set to a maximum height, with a scrollbar that kicks in if needed).
Closes #3852
Closes #3851
Closes #3812