Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@chenss3
Copy link
Contributor

@chenss3 chenss3 commented Sep 12, 2024

Summary of the pull request

User will no longer be allowed to interact or see the QSP UI in the machine configuration tab after the user has disabled the QSP experimental feature in settings

References and relevant issues

Resolves issue #3233

Detailed description of the pull request / Additional comments

With my changes, when the quickstartplaygroundviewmodel is loaded, it will check for the value of whether quickstartplayground experimental feature is enabled. If it's not, it will cancel out of the current setup flow and go back to the desired main page.

The reason why this issue is happening is the experiment service doesn't have an event that it sends out to tell subscribers that an experiments state has changed. The setup flow's viewmodel and orchestrator are singletons, so what ever flow the user currently selects, will stay on the screen. since there is no event nothing happens.

I think ideally, we wanted a more generic experimental feature solution where we could add an event to the experimentation service that the setup flow subscribes to, that when triggered, if the experiment is a flow in the setup flow, then we cancel out of the flow and go back to the machine setup flow page. However, with the current way that machine config is setup with its navigation and flow pages, it makes it more difficult to achieve that. Thus, for this PR, it will address specifically the qsp issue.

Also currently, with my solution, there is a one frame that flashes when the qsp view model is navigating back to the machine config main page.

Validation steps performed

locally built and verified

PR checklist

@AmelBawa-msft AmelBawa-msft added the Needs-Second Pull request that needs another approval label Sep 12, 2024
@chenss3 chenss3 requested a review from manodasanW September 16, 2024 20:28
@chenss3 chenss3 merged commit 28f4daf into main Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Needs-Second Pull request that needs another approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quickstart Playground can still be used after experimental feature is turned off

5 participants