This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fix accessibility issue for Hyperlinks in machine configurations summary page #3837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The last page for every machine configuration flow (except QuickStart Playground) is the summary page. The page contains 4 hyperlink buttons that either leads the user to another page in Dev Home or the For Developers Windows settings page. There are two accessibility issue with this link:
Changes:
BEFORE CHANGES
Video of showing scaling at 200% (Notice the hyperlinks have not underline and the "Change developer settings in windows" text is cut off. I start off the video using scaling at 200%:
before.changes.mp4
AFTER CHANGES
Video showing scaling at text scaling at 200% - Links are now underlined and the "Change developer settings in windows" text is now wrapped:
After.changes.mp4
video showing text scaling at 225%
After.changes.with.text.scalling.at.225.mp4
References and relevant issues
Fixes:
https://task.ms/50454382
https://task.ms/52330843
Detailed description of the pull request / Additional comments
When looking at the summary page, it looks like the elements are strictly contained in the uniform grid used for the entire page. So, that's why when resizing the page in the "After changes" video the text wraps even though from the users perspective it looks like there is still a lot of space for the text to flow without needing to wrap. I looked into this, and there needs to be a bigger change in how the summary page works in order to allow this to happen. Instead of strictly placing different user controls in quadrants of the uniformed grid we should be allowing these quadrants to freely expand and be resized based on the available space around them. I'll create an issue for this.
Validation steps performed
PR checklist