Skip to content

Fix reusing ASIO http_client connecting to HTTPS server via proxy #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillyONeal merged 2 commits into from
Jun 13, 2019
Merged

Fix reusing ASIO http_client connecting to HTTPS server via proxy #539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca1c529
Fix reusing ASIO http_client connecting to HTTPS server via proxy
vadz Sep 8, 2017
05af7d9
Merge remote-tracking branch 'origin/master' into pr/n539_fix-proxy-r…
BillyONeal Jun 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Release/src/http/client/http_client_asio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,8 @@ class asio_context final : public request_context, public std::enable_shared_fro
}
};

if (proxy_type == http_proxy_type::ssl_tunnel)
// Note that we must not try to CONNECT using an already established connection via proxy -- this would send CONNECT to the end server which is definitely not what we want.
if (proxy_type == http_proxy_type::ssl_tunnel && !m_connection->is_reused())
{
// The ssl_tunnel_proxy keeps the context alive and then calls back once the ssl tunnel is established via
// 'start_http_request_flow'
Expand Down