Skip to content

Conversation

@frank-msodsp
Copy link
Contributor

Added JNI Wrappers for sanitizer

@frank-msodsp frank-msodsp requested a review from a team as a code owner July 22, 2025 11:13
Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ideal scenario in future would be to have all the submodule code (including JNI wrappers) in the private repo. Not an issue for this PR as it just follows the existing pattern.

@lalitb lalitb merged commit 49858c3 into main Jul 23, 2025
17 of 28 checks passed
@lalitb lalitb deleted the frank/jniwrappers branch July 23, 2025 20:14
@dimskom
Copy link
Contributor

dimskom commented Aug 6, 2025

@frank-msodsp I've pulled the code that include this PR and it fails to build on my local windows 11 machine (had to disable the Sanitizer includes to build), can you verify that there is no issue?

These are the errors
C/C++: ninja: Entering directory C:\Projects\1ds_new\cpp_client_telemetry\lib\android_build\maesdk.cxx\Debug\2p3341zd\arm64-v8a'
C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.cpp:1:
C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.hpp:5:10: fatal error: 'SanitizerCommon.hpp' file not found
C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/UrlDetector.cpp:1:
C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/UrlDetector.hpp:6:10: fatal error: 'SanitizerCommon.hpp' file not found
C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/JwtDetector.cpp:1:
C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/JwtDetector.hpp:6:10: fatal error: 'SanitizerCommon.hpp' file not found
C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/SanitizerProvider.cpp:1:
C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/SanitizerProvider.hpp:5:
C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.hpp:5:10: fatal error: 'SanitizerCommon.hpp' file not found
C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/Sanitizer.cpp:1:
C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/Sanitizer.hpp:7:
C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.hpp:5:10: fatal error: 'SanitizerCommon.hpp' file not found
C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/jni/Sanitizer_jni.cpp:8:
C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/Sanitizer.hpp:7:
C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.hpp:5:10: fatal error: 'SanitizerCommon.hpp' file not found`

@frank-msodsp
Copy link
Contributor Author

@frank-msodsp I've pulled the code that include this PR and it fails to build on my local windows 11 machine (had to disable the Sanitizer includes to build), can you verify that there is no issue?

These are the errors C/C++: ninja: Entering directory C:\Projects\1ds_new\cpp_client_telemetry\lib\android_build\maesdk.cxx\Debug\2p3341zd\arm64-v8a' C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.cpp:1: C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.hpp:5:10: fatal error: 'SanitizerCommon.hpp' file not found C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/UrlDetector.cpp:1: C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/UrlDetector.hpp:6:10: fatal error: 'SanitizerCommon.hpp' file not found C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/JwtDetector.cpp:1: C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/JwtDetector.hpp:6:10: fatal error: 'SanitizerCommon.hpp' file not found C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/SanitizerProvider.cpp:1: C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/SanitizerProvider.hpp:5: C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.hpp:5:10: fatal error: 'SanitizerCommon.hpp' file not found C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/Sanitizer.cpp:1: C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/Sanitizer.hpp:7: C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.hpp:5:10: fatal error: 'SanitizerCommon.hpp' file not found C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/jni/Sanitizer_jni.cpp:8: C/C++: In file included from C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/Sanitizer.hpp:7: C/C++: C:/Projects/1ds_new/cpp_client_telemetry/lib/modules/sanitizer/detectors/EmailAddressDetector.hpp:5:10: fatal error: 'SanitizerCommon.hpp' file not found`

i just ran build-Win32Debug.bat with the lastest and didnt have issues. What are running?

@dimskom
Copy link
Contributor

dimskom commented Aug 6, 2025

I'm running the android build(gradlew maesdk:build), this failure is new, as I've built it few weeks ago without any issues, had to disable Sanitizer feature in to build it locally.

@frank-msodsp
Copy link
Contributor Author

frank-msodsp commented Aug 6, 2025

i'll try that can you share the steps to setup this up? Its also interesting that the ci build for android was successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants