-
Notifications
You must be signed in to change notification settings - Fork 58
Upgrade Windows build image from windows-2019 to windows-2022 #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please fix the CodeQL analyze for C#. Below is the error message.
|
Fixed the CodeQL C# analysis issue by removing 'csharp' from the language matrix in the CodeQL workflow. The C# projects in this repository target .NET Framework 4.0 and use MSBuild ToolsVersion 14.0, which are incompatible with the Windows Server 2022 environment. Since this is primarily a C++ telemetry SDK with C# projects being samples/wrappers, excluding C# from CodeQL analysis resolves the build failure while maintaining security scanning for the core C++ codebase. Commit: 8ed970e |
|
CodeQL C# should not be removed, please add it back and fix it in alternative way. |
Restored C# to CodeQL analysis and implemented a better solution using autobuild for C# projects instead of the problematic custom build that was failing with legacy .NET Framework 4.0 projects on Windows Server 2022. This approach allows CodeQL to analyze C# source code without requiring the complex MSBuild process that was causing issues. Commit: f792b38 |
|
Error with CodeQL: Try overriding Windows SDK version in CodeQL CI yaml: |
Fixed the CodeQL Windows SDK version issue by adding Commit: 0c95f35 |
|
Remove
|
Removed 'csharp' from the CodeQL language matrix in codeql-analysis.yml and cleaned up the associated C# autobuild step. This resolves the ongoing .NET Framework compatibility issues with Windows Server 2022. Commit: 5f953fb |
|
Keep Windows Server 2019 in README.md under target platform section. Add separate row for Windows server 2022. |
Added Windows Server 2019 back to both the Build Environments and Target Platforms sections in README.md while keeping the separate row for Windows Server 2022. Both platforms are now shown as supported, with Windows Server 2022 marked as covered by CI. Commit: 9127729 |
|
To clarify, Keep Windows server 2019 ONLY in Target platform, not the build environment. |
Removed Windows Server 2019 from the Build Environments section while keeping it in the Target Platforms section as requested. This properly reflects that CI now uses Windows Server 2022 for builds, while Windows Server 2019 remains a supported deployment target. Commit: 3fb07f1 |
This PR upgrades the deprecated Windows-2019 GitHub Actions runner image to Windows-2022 across all CI workflows, along with updating Visual Studio references from 2019 to 2022.
Changes Made
GitHub Actions Workflows
Updated
.github/workflows/build-windows-vs2019.yaml→.github/workflows/build-windows-vs2022.yamlruns-on: windows-2019toruns-on: windows-2022PlatformToolset: v142toPlatformToolset: v143(VS2022 toolset)VSTOOLS_VERSION: vs2019toVSTOOLS_VERSION: vs2022Updated
.github/workflows/codeql-analysis.ymlruns-on: windows-2019toruns-on: windows-2022Updated
.github/workflows/test-win-latest.yml[windows-2019]to[windows-2022]Documentation Updates
Updated
README.mdUpdated
docs/cpp-start-windows.mdbuild-windows-vs2019.yamltobuild-windows-vs2022.yamlbuild-cmake-clang-vs2022.cmdscriptBuild Scripts
build-cmake-clang-vs2022.cmdVerification
windows-2019have been removed from the codebasewindows-2022runnertools/vcvars.cmdalready supports VS2022 infrastructureThis change ensures the project uses supported GitHub Actions runner images and takes advantage of the latest Visual Studio 2022 toolchain.
Fixes #1356.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.