Fix Privacy Guard unit test failures #1304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuellopezleon
approved these changes
Oct 7, 2024
Contributor
|
MacOS CI tests are not running for #1299, we should be good to force merge to unblock privacy guard CI. |
Contributor
|
Does this apply to the privacy guard module, or all modules for cpp_client_telemetry?
|
Contributor
Author
It is for the privacy guard module in 1DS C++ SDK only. Similar situation may apply to other components in the *_modules repo, though, it's up to them whether they want to do the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes Privacy Guard related unit test and functional test failures.
They were not discovered earlier because some of the test cases are not run in 1DS C++ SDK main repo build pipelines - privacy guard is in submodule repo, so main repo does not compile them along with public SDK files, hence some unit tests are disabled using a macro.
I discussed with Lalit and the agreement we settled is that developers need to run all unit test locally before submitting PR for review. I also modified our developers guide to include this in Privacy Guard team guide.