Skip to content

Conversation

@DSMitten
Copy link
Contributor

A few files use types defined in headers that are missing, and this is revealed through build errors when building with gcc. Something about libstdc++ may have refactored header files such that headers that previously were inherited now must be explicitly included.

fixes #1288

@DSMitten DSMitten requested a review from a team as a code owner July 12, 2024 19:54
Copy link
Contributor

@mkoscumb mkoscumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomsonTan
Copy link
Contributor

Seems all iOS build are broken, are they relatied?

@lalitb
Copy link
Contributor

lalitb commented Jul 17, 2024

Seems all iOS build are broken, are they relatied?

#1287

@ThomsonTan ThomsonTan merged commit 5116b27 into main Aug 14, 2024
@ThomsonTan ThomsonTan deleted the user/smitten/gcc13fix branch August 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cpp_client_telemetry fails to build with gcc13

5 participants