Skip to content

Conversation

@ShrutiJaiswal1494
Copy link
Contributor

@ShrutiJaiswal1494 ShrutiJaiswal1494 commented Jul 11, 2024

Introduce memset_s in sqlite3

@ShrutiJaiswal1494 ShrutiJaiswal1494 marked this pull request as ready for review July 11, 2024 17:59
@ShrutiJaiswal1494 ShrutiJaiswal1494 requested a review from a team as a code owner July 11, 2024 17:59
@lalitb lalitb changed the title Add memset_s to fix buffer overflow for memset function in sqlite3 Introduce memset_s in sqlite3 Jul 12, 2024
@lalitb
Copy link
Contributor

lalitb commented Jul 16, 2024

@ShrutiJaiswal1494 - Can you address the open comments? It was agreed in today's community meeting that the changes can proceed.

Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the comments.

Copy link
Contributor

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@lalitb
Copy link
Contributor

lalitb commented Jul 24, 2024

Doing force merge, as the mac CI is failing for older virtual images

@lalitb lalitb merged commit 24bb518 into main Jul 24, 2024
@lalitb lalitb deleted the user/shjaiswal/CodeQLFixSQLiteBug branch July 24, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants