Remove go wrapper #1268
Merged
Remove go wrapper #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yeah, it was used by BingAds. You can most likely remove it safely. I am not aware of other customers. |
maxgolov
approved these changes
Apr 30, 2024
lalitb
approved these changes
Apr 30, 2024
reyang
approved these changes
Apr 30, 2024
Contributor
|
The CI errors are not related to this PR, possibly related to the recent macOS runner image changes. We can address that separately, and force merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go wrapper is not in complete shape. As we haven't heard about ask of this for years, I'd delete it from the repo now to avoid any maintenance burden for it.
We can always bring it back once we need it.