Skip to content

Add noexcept annotation where applicable #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoscumb merged 4 commits into from
Feb 5, 2024
Merged

Add noexcept annotation where applicable #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9fbb90
NetworkDetector::RegisterAndListen does not throw exceptions, thus ma…
mkoscumb Feb 2, 2024
bcf75ba
RequestHandler::RequestHandler does not throw exceptions, thus mark t…
mkoscumb Feb 2, 2024
35da2e9
Constant intialization of member variables should be done using in-cl…
mkoscumb Feb 2, 2024
d0f3229
Merge branch 'main' into user/makoscum/AddNoexceptAnnotation
mkoscumb Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pal/desktop/NetworkDetector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ namespace MAT_NS_BEGIN
return true;
}

bool NetworkDetector::RegisterAndListen()
bool NetworkDetector::RegisterAndListen() noexcept
{
// ???
HRESULT hr = pNlm->QueryInterface(IID_IUnknown, (void**)&pSink);
Expand Down
2 changes: 1 addition & 1 deletion lib/pal/desktop/NetworkDetector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ namespace MAT_NS_BEGIN
/// Register and listen to network state notifications
/// </summary>
/// <returns></returns>
bool RegisterAndListen();
bool RegisterAndListen() noexcept;

/// <summary>
/// Reset network state listener to uninitialized state
Expand Down
4 changes: 2 additions & 2 deletions tests/functests/MultipleLogManagersTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ using namespace MAT;
class RequestHandler : public HttpServer::Callback
{
public:
RequestHandler(int id) : m_count(0), m_id(id){}
RequestHandler(int id) noexcept : m_id(id){}

int onHttpRequest(HttpServer::Request const& request, HttpServer::Response& /*response*/) override
{
Expand All @@ -54,7 +54,7 @@ class RequestHandler : public HttpServer::Callback
}

private:
size_t m_count;
size_t m_count {};
int m_id ;
};

Expand Down