Skip to content

Fixing release build unused variable error by adding conditional complation to the code run only for debug builds #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
absaroj merged 2 commits into from
Feb 2, 2024
Merged

Fixing release build unused variable error by adding conditional complation to the code run only for debug builds #1240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1109245
adding conditional compliation for the code which is supposed to run …
absaroj Feb 2, 2024
88ebeb9
Merge branch 'main' into user/absaroj/fix_locla
absaroj Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/offline/SQLiteWrapper.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,9 @@ namespace MAT_NS_BEGIN {
}

bool lock() {
#ifndef NDEBUG
unsigned count = 0;
#endif
unsigned waitTime = 0;
while (!trylock()) {
if (waitTime >= MAX_DB_LOCKWAIT_DELAY) {
Expand All @@ -452,8 +454,10 @@ namespace MAT_NS_BEGIN {
return false;
}
waitTime += MAX_DB_LOCKWAIT_DELAY; // 500ms, 1000ms
#ifndef NDEBUG
count++;
LOG_DEBUG("Lock: waiting to acquire the lock: count=%u, waitTime=%u", count, waitTime);
#endif
PAL::sleep(MAX_DB_LOCKWAIT_DELAY);
}
LOG_DEBUG("Lock: acquired [time=%u]", waitTime);
Expand Down