Skip to content

Fix a few variable shadowing warnings in public headers. #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkoscumb merged 5 commits into from
Feb 6, 2024
Merged

Fix a few variable shadowing warnings in public headers. #1233

mkoscumb merged 5 commits into from
Feb 6, 2024

Conversation

@mkoscumb
Copy link
Contributor

@mkoscumb mkoscumb commented Jan 24, 2024

I'm happy to change the names or suppress these warnings as well.

@mkoscumb mkoscumb requested a review from a team as a code owner January 24, 2024 17:26
ThomsonTan
ThomsonTan approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@ThomsonTan ThomsonTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@mkoscumb mkoscumb merged commit e6dcf9a into main Feb 6, 2024
@mkoscumb mkoscumb deleted the user/makoscum/FixVariableShadowingWarnings branch February 6, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkoscumb @ThomsonTan