Skip to content

Conversation

@absaroj
Copy link
Contributor

@absaroj absaroj commented Jan 11, 2024

Two test files were left out without cleanup after mbu test for ariasdk. Adding change to clean them up.

Fix:

test.ses:

reason for this being left out after mbu test is due to TEST method is being used insteasd of TEST_F which is with fixture responsible for calling the setup and tear down functions of the test class.
more info at: link (Opens in new window or tab)

sesfile.ses:
this is being left out since the cleanup funcitons are not being called after the setup.

@absaroj absaroj requested a review from a team as a code owner January 11, 2024 02:22
Copy link
Contributor

@mkoscumb mkoscumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@absaroj absaroj merged commit 2f63392 into main Jan 11, 2024
@absaroj absaroj deleted the absaroj/clean_files_test branch January 11, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants