Fix an Apple break in Office around complex c'tors running at binary load time. #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
approved these changes
Jan 8, 2024
Contributor
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix.
mkoscumb
deleted the
mkoscumb/FixGlobalInitializerFailureInMemoryStorageTests
branch
absaroj
reviewed
Jan 9, 2024
| /// <summary> | ||
| /// Storage observer | ||
| /// </summary> | ||
| TestObserver testObserver; |
Contributor
There was a problem hiding this comment.
do we need TearDown for this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is to move the complex c'tors into a Test Facet, so that they're initialized and destroyed only when the Test is run.