Add target .net 6 for the 1DS Test Server #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-iankudinova
requested review from
ThomsonTan,
bliptec,
kindbe,
lalitb,
maxgolov,
mkoscumb and
reyang
as code owners
ThomsonTan
reviewed
Oct 3, 2023
maxgolov
approved these changes
Oct 5, 2023
ms-iankudinova
deleted the
user/iankudinova/test_support_both_frameworks
branch
ms-iankudinova
added a commit
that referenced
this pull request
May 13, 2024
* Update .net version to .net 6 * support both frameworks .net6 and old one .net core 3 * Update scripts, that runs test server to specify flags for target frameworks * Change indent * Use $framework value in the echo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our e2e tests, when we are using 1DS Test Server, pipeline uses .net6 (we have been targeting custom branch with the change
user/iankudinova/update_server_to_net6).I want to add the support .net6 to the main branch.
In case at some other project / plcases .net core 3 is used for the Test telemetry server I kept both version.
So Users will have to specify --framework version, when they run server.
Existed scripts:
run.cmdrun.shwere updated to support --framework option and use .net core 3 as a default option