Revert fix for upload thread stoppage and max priority #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivpratap1992
requested review from
bliptec,
kindbe,
lalitb,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
tomkaragounis
pushed a commit
that referenced
this pull request
Mar 27, 2025
Fix bombarding of Max priority events and normal priority thread stop… (#1206) * Fix bombarding of Max priority events and normal priority thread stoppage * Test (#1211) Add fix for max priority and stopped upload thread (#1212) * Validate Max Priority for Mac failure * Test Event Arrived m_isUploadScheduled * Test Cancel and Event Arrived m_isUploadScheduled * Test Event Arrived m_isUploadScheduled false * Remove constructor initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS is failing due to some code in this PR. Hence reverting this change for time being until we fix exact issue to ensure correct MIP SDK 1DS pipeline