Skip to content

Replace PAL's to_string with std::to_string. #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoscumb merged 4 commits into from
Jun 26, 2023
Merged

Replace PAL's to_string with std::to_string. #1177

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
990493b
Replace hand-crafted to_string method with std::to_string.
mkoscumb Jun 23, 2023
dffe2bc
Get rid of PAL::to_string.
mkoscumb Jun 23, 2023
59e46f5
Explicitly invoke std::string's c'tor with brace-initialization.
mkoscumb Jun 23, 2023
4870821
Merge branch 'main' into user/mkoscumb/ReplaceToStringWithStd
mkoscumb Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 13 additions & 36 deletions lib/utils/StringUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,42 +36,19 @@ namespace MAT_NS_BEGIN
return (stringToTest.find_first_not_of(allowlist) == string::npos);
}

#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-value"
#endif
/**
* Convert various numeric types and bool to string in an uniform manner.
*/
template<typename T>
std::string to_string(char const* format, T value)
{
static const int buf_size = 40;
char buf[buf_size] = { 0 };
#ifdef _WIN32
::_snprintf_s(buf, buf_size, format, value);
#else
snprintf(buf, buf_size, format, value);
#endif
return std::string(buf);
}
#ifdef __clang__
#pragma clang diagnostic pop
#endif

std::string toString(char const* value) { return std::string(value); }
std::string toString(bool value) { return value ? "true" : "false"; }
std::string toString(char value) { return to_string("%d", static_cast<signed char>(value)); }
std::string toString(int value) { return to_string("%d", value); }
std::string toString(long value) { return to_string("%ld", value); }
std::string toString(long long value) { return to_string("%lld", value); }
std::string toString(unsigned char value) { return to_string("%u", value); }
std::string toString(unsigned int value) { return to_string("%u", value); }
std::string toString(unsigned long value) { return to_string("%lu", value); }
std::string toString(unsigned long long value) { return to_string("%llu", value); }
std::string toString(float value) { return to_string("%f", value); }
std::string toString(double value) { return to_string("%f", value); }
std::string toString(long double value) { return to_string("%Lf", value); }
std::string toString(char const* value) { return std::string { value }; }
std::string toString(bool value) { return value ? std::string { "true" } : std::string { "false" }; }
std::string toString(char value) { return std::to_string(static_cast<signed char>(value)); }
std::string toString(int value) { return std::to_string(value); }
std::string toString(long value) { return std::to_string(value); }
std::string toString(long long value) { return std::to_string(value); }
std::string toString(unsigned char value) { return std::to_string(value); }
std::string toString(unsigned int value) { return std::to_string(value); }
std::string toString(unsigned long value) { return std::to_string(value); }
std::string toString(unsigned long long value) { return std::to_string(value); }
std::string toString(float value) { return std::to_string(value); }
std::string toString(double value) { return std::to_string(value); }
std::string toString(long double value) { return std::to_string(value); }

std::string toLower(const std::string& str)
{
Expand Down