Add some const qualifiers identified by static analysis #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoscumb
requested review from
ThomsonTan,
bliptec,
kindbe,
lalitb,
maxgolov,
reyang and
sid-dahiya
as code owners
lalitb
approved these changes
Jun 12, 2023
ThomsonTan
reviewed
Jun 13, 2023
| record.extSdk[0].libVer = PAL::getSdkVersion(); | ||
| #endif | ||
| auto sessionData = m_owner.GetLogSessionData(); | ||
| const auto* sessionData = m_owner.GetLogSessionData(); |
Contributor
There was a problem hiding this comment.
Does this changing the type of sesstionData (removing pointer), and is this expected? #Closed
Contributor
There was a problem hiding this comment.
Ok, seems the variable type is not change, it is just required to be a pointer.
Contributor
Author
There was a problem hiding this comment.
Correct, this has no change to the type but it's cv qualifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.