Do not call Settings.Secure.ANDROID_ID #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anod
requested review from
ThomsonTan,
bliptec,
kindbe,
lalitb,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
anod
force-pushed
the
algavris/android_device_id
branch
3 times, most recently
from
f58ee45 to
0063b27
Compare
anod
force-pushed
the
algavris/android_device_id
branch
from
0063b27 to
e17e3e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a requirement to avoid calling Settings.Secure.ANDROID_ID before user consent,
Add configuration to HttpClient to avoid calling setDeviceInfo in constructor