adding swift wrapper for DiagnosticDataViewer #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absaroj
requested review from
ThomsonTan,
bliptec,
kindbe,
lalitb,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
eduardo-camacho
approved these changes
May 9, 2023
Contributor
eduardo-camacho
left a comment
eduardo-camacho
left a comment
There was a problem hiding this comment.
Please get review from Lalit and Sid as well
lalitb
approved these changes
May 10, 2023
Contributor
There was a problem hiding this comment.
LGTM. Thanks. Is there any plan to update main.swift for basic tests on this wrapper ?
mannie
reviewed
May 10, 2023
mannie
reviewed
May 15, 2023
mannie
approved these changes
May 18, 2023
eduardo-camacho
approved these changes
May 24, 2023
Contributor
|
Merging to unblock. The iOS build is stuck not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.