Android, upgrade room and test deps, cleanup not required #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anod
requested review from
bliptec,
kindbe,
lalitb,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
maxgolov
reviewed
Mar 23, 2023
| // | ||
| package com.microsoft.applications.events.maesdktest; | ||
|
|
||
| import androidx.annotation.Keep; |
Contributor
There was a problem hiding this comment.
Wasn't this necessary to avoid the obfuscator from stripping/changing the method signature?
Member
Author
There was a problem hiding this comment.
This is app that executes tests, is not part of maesdk
maxgolov
approved these changes
Mar 23, 2023
Contributor
maxgolov
left a comment
maxgolov
left a comment
There was a problem hiding this comment.
LGTM - except the Keep part, please elaborate on this one.
anod
force-pushed
the
algavris/deps-cleanup
branch
from
70d8845 to
95df2b4
Compare
lalitb
approved these changes
Mar 27, 2023
anod
force-pushed
the
algavris/deps-cleanup
branch
from
95df2b4 to
1058d4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of #1103
Upgrade room 2.2.6 -> 2.4.3 (latest 2.5.1)(requires java upgrade)Upgrade espresso-core
Clean not needed libraries
Move HttpClientRequestTest to the library project, so it will run during build