Add HTTP/2 support to HTTPClient_Curl #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
requested review from
bliptec,
kindbe,
maxgolov,
mkoscumb,
reyang and
sid-dahiya
as code owners
ThomsonTan
reviewed
Mar 13, 2023
| curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0); // 1L | ||
| curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0); // 2L | ||
| // HTTP/2 please, fallback to HTTP/1.1 if not supported | ||
| curl_easy_setopt(curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_0); |
Contributor
There was a problem hiding this comment.
The new line of API call says using version 2.0, will it fallback automatically, or any extra parameter needed?
Contributor
Author
There was a problem hiding this comment.
Yes, it will fallback automatically to using HTTP/1.1 if
- curl is built without the nghttp2 library.
- the collector is not supporting HTTP/2.0
ThomsonTan
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to add HTTP/2 support to
HTTPClient_curl. It will fallback to HTTP/1.1 if either of client or server doesn't support HTTP/2.