Add missing existingFoundryProjectResourceId parameter to main.parameters.waf.json #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates
infra/main.parameters.waf.json
to include all parameters defined in the Bicep template, making it consistent with the standardmain.parameters.json
file.Problem
The
main.parameters.waf.json
file was missing theexistingFoundryProjectResourceId
parameter, which is:infra/main.bicep
as an optional parameterinfra/main.parameters.json
fileThis inconsistency meant that WAF deployments could not take advantage of the existing AI Foundry project feature, even though the Bicep template supports it.
Changes
Added the missing parameter to
infra/main.parameters.waf.json
:Result
The WAF parameters file now contains:
enablePrivateNetworking
parameter set to"true"
(specific to WAF deployments)This ensures that both standard and WAF deployments have access to the same configurable parameters, maintaining consistency across deployment types.
Validation
main.parameters.json
are now present inmain.parameters.waf.json
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.ms
bicep build main.bicep
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.